{AKS} create managed namespace commands #8689
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks namespace | sub group aks namespace added |
|
Hi @xmzhao0822, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
xmzhao0822
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces managed namespace commands for AKS including add, update, show, list, delete, and get-credentials. Key changes include a version bump in setup.py, new functionality and validations for managed namespaces with supporting tests, and updates to CLI command definitions and help documentation.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumps version to 18.0.0b3 to correspond with the new managed namespace features. |
| src/aks-preview/azext_aks_preview/tests/latest/test_validators.py | Adds a ManagedNamespace class and new tests for namespace name and resource quota validations. |
| src/aks-preview/azext_aks_preview/tests/latest/test_managednamespace.py | Provides tests that cover invalid and valid scenarios for adding/updating managed namespaces. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Includes integration-level tests for the new namespace commands. |
| src/aks-preview/azext_aks_preview/managednamespace.py | Implements functions to construct and update managed namespace configurations. |
| src/aks-preview/azext_aks_preview/custom.py, commands.py, _validators.py, _params.py, _help.py, _format.py, _consts.py, _client_factory.py | Update CLI command definitions, argument parsing, help texts, formatting of output, and constant definitions for the managed namespace commands. |
| src/aks-preview/HISTORY.rst | Updates the history with the new version and feature description. |
src/aks-preview/azext_aks_preview/tests/latest/test_validators.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
- test_aks_managed_namespace
|
Please resolve these conflicts |
|
@xmzhao0822 Could you please resolve this conflict? |
|
Applied fix for failed test cases in PR #8798 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125543338&view=results |
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks namespace add -g --cluster-name --name
az aks namespace show -g --cluster-name --name
az aks namespace list -g --cluster-name
az aks namespace update -g --cluster-name --name
az aks namespace delete -g --cluster-name --name
az aks namespace get-credentials -g --cluster-name --name
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.